Name an entity's own columns before the ones it inherits - #16
Merged
Conversation
Folding inherited properties (#15) gives every entity the columns it persists, in the order the class reads them -- root down, base first. Two summaries then take the first few of that list, and on an application with a shared audit base the first few are the base's for every entity at once. The agent context's entity table, on a base of six audit columns: before Invoice Number, IssuedOn, Total, Customer after #15 Invoice CreatedBy, CreatedOn, ChangedBy, ChangedOn, RowVersion now Invoice Number, IssuedOn, Total, Customer, CreatedBy Not one of Invoice's own columns survived a five-slot window. Across a fixture of seven entities, six rows carried the identical five names -- a table whose whole job is to tell entities apart, unable to. Customer kept one column by accident, because a required property outranks the rest. The fold itself is right and the full listings are unaffected: they still read root down, the way the class does. Only the summaries change, and only in which end of the list they spend a fixed width on. InheritedFrom, added in #15 for a renderer that had not been written yet, is what they sort by -- own first, then the inherited ones in their existing ranking, filling whatever slots are left. Every row now names what makes it different before what it shares. The same eight-slot summary in the navigation section of the published documents had it too. One fix per reader. The corpora #15 was verified against could not have shown this: FeatureCenter folds about one property per entity, MainDemo 26 over 17, and the 196-entity legacy application 0 -- its shared base declares no columns. The shape that hurts is the one the issue named, an audit base wider than the entities under it, and no fixture had it. AuditedXpoSolution is that shape. Found reviewing #15. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
#15 landed without an entry, and it is the largest user-visible change in the batch: every entity's property list is different. The release notes for 0.13.0 are assembled from [Unreleased], so an omission here is an omission there. One bullet rather than two. The window where an entity's own columns fell out of a five-slot summary existed only between the fold landing and this branch -- it was never released, and a changelog that documents it is describing a version nobody can install. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #15, found reviewing it.
What happens
Folding inherited properties gives every entity the columns it persists, in the order the class reads them — root down, base first. Two summaries then take the first few of that list, and on an application with a shared audit base the first few are the base's for every entity at once.
The agent context's entity table, measured on a base of six audit columns:
Invoice— notable propertiesNumber,IssuedOn,Total,CustomerCreatedBy,CreatedOn,ChangedBy,ChangedOn,RowVersionNumber,IssuedOn,Total,Customer,CreatedByNot one of
Invoice's own columns survived a five-slot window. Across a seven-entity fixture, six rows carried the identical five names — a table whose whole job is to tell entities apart, unable to.Customerkept one column by accident, because a required property outranks the rest.The same eight-slot summary in the navigation section of the published documents had it too. One fix per reader, or the reader who gets missed keeps the defect.
Why the corpora in #15 could not have shown it
FeatureCenter.NET.XPOMainDemo.NET.XPOAll three have thin bases. The shape that hurts is the one #13 named — an audit base wider than the entities under it — and no fixture had it.
AuditedXpoSolutionis that shape: six inherited columns against two or three own ones. It is kept apart fromDeepXpoSolution, whose tests pin exact property lists on a base of one column; the inverted proportion is the whole point of the new one.How it decides
InheritedFrom, added in #15 for a renderer that had not been written yet, is what the summaries sort by — own first, then the inherited ones in their existing ranking, filling whatever slots are left.OrderByDescendingis a stable sort, so within each group the root-down order #15 established is preserved.The fold itself is right and the full listings are unaffected: they still read root down, the way the class does. Only the two fixed-width summaries change, and only in which end of the list they spend their width on.
Deliberately out of scope: a
[PersistentAlias]on a shared base now makes every descendant report calculated properties (XafDetailTools,HtmlExplainerGenerator). That is redundancy rather than loss — the alias does apply to the descendant — and it belongs with the editorial half of #14.Verification
299 tests, 0 warnings. Three of the four new tests fail on
main:The fourth,
TheBaseItselfStillNamesItsOwnColumns, passes both before and after on purpose: it exists so nobody "fixes" this by hiding inherited properties, which would blank the base's own row — the same defect facing the other way.🤖 Generated with Claude Code